-
Notifications
You must be signed in to change notification settings - Fork 834
Refine the mobile message composer #2730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3cfd0f6
Refine the mobile message composer
klopez4212 f9924e9
Address mobile composer review feedback
klopez4212 479cffd
Sanitize mobile attachment filenames
klopez4212 dd3872e
Merge remote-tracking branch 'origin/main' into kennylopez-mobile-com…
klopez4212 0532f36
Restore composer emoji picker action
6e89bce
Open local attachments with media auth
eabeac0
Delete temporary inline camera captures
f1dda3a
Update iOS pod lock for attachment opener
f8875d9
Polish mobile composer capture and formatting
klopez4212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import 'dart:io'; | ||
|
|
||
| import 'package:image_picker/image_picker.dart'; | ||
|
|
||
| Future<void> processCapturedImage( | ||
| XFile image, | ||
| Future<void> Function(XFile image) onCapture, | ||
| ) async { | ||
| try { | ||
| await onCapture(image); | ||
| } finally { | ||
| final path = image.path; | ||
| if (path.isNotEmpty) { | ||
| try { | ||
| await File(path).delete(); | ||
| } on FileSystemException { | ||
| // The camera plugin may already have removed its temporary file. | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces a public mobile helper without a dartdoc, while the repo guide requires doc comments for new public API. Because it is only used by the private compose-bar part, please either make it private or add a doc comment so it does not become undocumented library surface.
AGENTS.md reference: AGENTS.md:L111-L114
Useful? React with 👍 / 👎.