Restore Goose and Buzz Agent to onboarding harness selection#2731
Open
morgmart wants to merge 3 commits into
Open
Restore Goose and Buzz Agent to onboarding harness selection#2731morgmart wants to merge 3 commits into
morgmart wants to merge 3 commits into
Conversation
Reverts the launch-only restriction from #2233 by adding goose and buzz-agent back to ONBOARDING_RUNTIME_ORDER — the single centralized onboarding visibility allowlist. Setup cards, readiness handoff, and the defaults harness picker all follow from that one list. Also generalizes the empty-state copy and updates the unit + E2E specs that pinned the hidden behavior.
With Goose and Buzz Agent restored, the 2x2 grid read as two tiers. A single lg:grid-cols-4 row (falling back to 2-up below lg and 1-up on narrow viewports) presents the four harnesses as peers.
…ding-harnesses * origin/main: ci: add Windows and Linux canary workflows with caching (#2642) fix(onboarding): show real install errors and fix concurrent install state (#2658) feat(node): add Windows managed Node.js fallback (win-x64 + win-arm64) (#2661) fix(desktop): parse runtime team instructions section (#2645) Match create-channel template selector styling (#2654) feat(desktop): make pull request reviews actionable (#2510) fix(desktop): shared-compute usability — share toggle, usage indicator, model resync (#2448) fix(desktop): refine focused thread dismissal targets (#2644) fix(relay): decompress gzip-encoded git smart-HTTP request bodies (#2670) Clarify agent harness defaults in create flow (#2601)
morgmart
marked this pull request as ready for review
July 25, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Part 1 of a multi-PR onboarding rework. This PR only restores the hidden harnesses and adjusts the card layout. A follow-up PR (stacked on this branch) restructures the flow: the harness page becomes a single-choice "pick your default harness" step, and install/sign-in/provider setup moves to the following page. Review this one on its own terms — the flow rework is intentionally not here.
Summary
ONBOARDING_RUNTIME_ORDERinonboardingRuntimeSelection.ts) that Hide bundled harnesses from onboarding #2233 deliberately set up for this moment — setup cards, readiness handoff, and the defaults harness picker all derive from itlg:grid-cols-4, falling back to 2-up belowlgand 1-up on narrow viewports) so the harnesses read as peers rather than tiersnot_installedsince they are always instantly ready when available (no sign-in step)Testing
onboardingRuntimeSelection.test.mjs— 4 passedpnpm typecheck— cleanpnpm exec playwright test tests/e2e/onboarding-agent-defaults.spec.ts --project=smoke— 18 passed (post-merge with main)onboarding-docked-cta-screenshots.spec.ts— 3 passed