Skip to content

Refine community management flows#2738

Open
klopez4212 wants to merge 3 commits into
mainfrom
kennylopez-add-community-modal
Open

Refine community management flows#2738
klopez4212 wants to merge 3 commits into
mainfrom
kennylopez-add-community-modal

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • simplify Add community into clear create and join paths
  • align community actions and icon editing across the rail, profile menu, and settings
  • consolidate invites around the member list and a reusable link dialog

Testing

  • pnpm check
  • pnpm test (3,483 passed)
  • pnpm run build:e2e
  • focused Playwright coverage (34 passed)

Snapshots

Add a community Join an existing community
Add a community Join an existing community
Create a new community Hosted community icon
Create a new community Hosted community icon
Invites Invite link
Invites Invite link

@klopez4212
klopez4212 marked this pull request as ready for review July 24, 2026 17:55
@klopez4212
klopez4212 requested a review from a team as a code owner July 24, 2026 17:55
klopez4212 added a commit that referenced this pull request Jul 24, 2026
@klopez4212

Copy link
Copy Markdown
Contributor Author

🤖 Final community management snapshots.

Add a community

01-add-community

Join an existing community

02-join-community

Create a new community

03-create-community

Hosted community icon

04-community-icon

Invites

05-invites

Invite link

06-invite-link

@klopez4212
klopez4212 marked this pull request as draft July 24, 2026 17:56
@klopez4212
klopez4212 marked this pull request as ready for review July 24, 2026 18:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50191b72a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/communities/ui/AddCommunityDialog.tsx Outdated
@klopez4212
klopez4212 requested a review from wesbillman July 24, 2026 18:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50191b72a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/communities/ui/AddCommunityDialog.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

const normalizedRelayUrl = React.useMemo(
() => (onConnect && !parsed ? normalizeRelayUrl(inviteInput) : null),
[inviteInput, onConnect, parsed],

P2 Badge Treat bare hostnames as community URLs

In add-community mode, entering a hostname like relay.example.com is parsed as a bare invite code, so parsed is truthy and this fallback never calls normalizeRelayUrl; because this dialog has no defaultRelayUrl, canSubmit stays false and the Join button remains disabled. The removed Add Community form accepted the same input by wrapping it with wss://, so this regresses a common relay entry form; treat bare hostnames as relay URLs before bare-code parsing or allow this normalization path to run.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/sidebar/ui/CommunityRail.tsx
@klopez4212

Copy link
Copy Markdown
Contributor Author

🤖 Addressed the bare-hostname review in 21bf06f34: add-community now restores the legacy scheme-less host behavior, normalizing relay.example.com to wss://relay.example.com before treating it as an unusable bare invite code. The API-token E2E covers the scheme-less path, and the five previously failing integration tests now pass locally.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21bf06f34b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant