feat(desktop): auto-replace ASCII emoticons in the composer#2762
Open
laleshii wants to merge 1 commit into
Open
feat(desktop): auto-replace ASCII emoticons in the composer#2762laleshii wants to merge 1 commit into
laleshii wants to merge 1 commit into
Conversation
laleshii
force-pushed
the
feat/composer-emoticon-autoreplace
branch
from
July 24, 2026 21:33
36cac61 to
9c2b8ff
Compare
Typing standalone smileys like :) :P ;) <3 now converts them to the matching unicode emoji as soon as the pattern completes, the same way :shortcode: custom emoji already do. Requires a preceding space/start so it doesn't fire mid-word, and is a no-op inside code blocks/inline code and on pasted text (Tiptap's input-rule plugin only hooks live keystrokes). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Rares S <rrr.junior@gmail.com>
laleshii
force-pushed
the
feat/composer-emoticon-autoreplace
branch
from
July 24, 2026 21:55
9c2b8ff to
9341706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:),:(,:D,;),:P,:O,:|,:*,B),XD,<3,</3, and:--prefixed variants) in the message composer now auto-converts it to the matching unicode emoji the instant the pattern completes — the same "convert on completion" behavior the composer already uses for known:shortcode:custom emoji.hi:)stays literal,hi :)and a message starting with:)both convert).Test plan
emoticonMap.test.mjs)composer-emoticon-autoreplace.spec.ts) covering: basic conversion, multiple emoticons in one message, incomplete patterns, mid-word non-conversion, message-starts-with-emoticon, space-triggered conversion, continued typing after conversion, paste non-conversion, and inline-code non-conversion — all passingtsc --noEmitandbiome checkclean