Remove unreachable 'No devices available' guard#2
Merged
afollestad merged 1 commit intoblock:mainfrom Feb 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes an unreachable “No devices available” early-return in openUrlInAvailableEmulator, aligning the control flow with the fact that “Open on this computer” and “Skip” are always present options.
Changes:
- Deleted the dead
availableOptions.isEmptyguard and its message/return path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
You'll have to rebase with main for conflicts 😅 |
jackfreem
force-pushed
the
jf/RemoveDeadNoDevicesGuard
branch
from
9840b3c to
890c121
Compare
afollestad
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openUrlInAvailableEmulator, the guardif availableOptions.isEmptycan never be true — "Open on this computer" and "Skip" are always appended unconditionally before itTesting
.build/debug/qrgo