Reopening Token Metadata fix #410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Hello @leo42, could you provide an example of an asset affected by this change? I want to be be sure we fully understand the exact issue this PR is addressing. Looking at changes it is about CIP68v2 metadata where keys in the metadata map are not correctly encoded? OG lucid did allow encoding keys as bytes, so I am kinda surprised that lucid evolution does not. |
Author
|
https://preprod.cexplorer.io/asset/asset1gzsmanw53g78sktg78zaccezaa274qhxvu8hcy/metadata#data
I see the metadata in the explorer and in Eternal, but since the app I am
maintaining uses Blackfrost I am unable to get the assets name(need it for
some UX improvements)
…On Wed, May 14, 2025 at 5:05 PM Maroš ***@***.***> wrote:
*slowbackspace* left a comment (blockfrost/openapi#410)
<#410 (comment)>
Hello @leo42 <https://github.com/leo42>, could you provide an example of
an asset affected by this change? I want to be be sure we fully understand
the exact issue this PR is addressing.
Looking at changes it is about CIP68v2 metadata where keys in the metadata
map are not correctly encoded? OG lucid did allow this, so I am kinda
surprised that lucid evolution does not.
—
Reply to this email directly, view it on GitHub
<#410 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBLGXNI43UL4NOYTWZNEFD26NEUFAVCNFSM6AAAAAB5DKOP6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBQGM4DGNZVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After over a year, all other major indexers wallets and explorers are accepting this format.
Tools like Lucid evolution do not even allow encoding labels in the metadata as byte arrays, please reconsider merging this fix, it is just one extra layer of fallback before giving up and registering null tokenMetadata