Repository navigation
feat(dashboard): add Shutter Security Council card - #2168
Merged
Merged
Conversation
Shutter's veto runs through Snapshot X: the Security Council (5-of-8 Safe 0x3ea7...c0C0) owns the Snapshot X space (0x594E...B769) and vetoes a proposal by calling Space.cancel(proposalId) before execution. Point the DAO Overview Security Council card at that multisig. Unlike ENS's renewable term or Compound's guardian expiry, this veto is an owner privilege with no fixed term. Add a `noExpiration` flag to the securityCouncil config; when set, the card shows "No expiration" instead of a countdown and drops the progress/danger bar (ENS and Compound keep their expiration blocks and behavior).
alextnetto
requested review from
LeonardoVieira1630,
PedroBinotto,
brunod-e,
isadorable-png and
pikonha
as code owners
September 29, 2026 19:40
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
🎨 UI Review
Security Council card — Shutter (
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac8e8a00d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const progress = useMemo(() => { | ||
| if (!securityCouncil) return 0; | ||
| if (!securityCouncil || securityCouncil.noExpiration) return 0; |
There was a problem hiding this comment.
When noExpiration is true, returning 0 only suppresses the danger zone; SecurityCouncilCard still renders ProgressBar, whose unconditional markup shows the timeline track, orange marker, and zero-width gradient. Shutter therefore displays a misleading zero-progress expiration timeline despite being configured with no fixed term. Conditionally omit the graphical progress bar or render a dedicated indefinite-term layout instead.
Useful? React with 👍 / 👎.
|
🚅 Deployed to the anticapture-pr-2168 environment in anticapture-infra
|
railway-app
Bot
temporarily deployed
to
anticapture-infra / anticapture-pr-2168
September 29, 2026 19:46
Destroyed
Drop the separate `noExpiration` flag added in the previous commit and treat `securityCouncil.expiration.timestamp === 0` as "no fixed term" instead. This keeps a single source of truth (the timestamp itself) and matches the convention useCountdown already uses (it treats timestamp <= 0 specially). The card still shows "No expiration" and hides the progress/danger bar for Shutter; ENS and Compound keep their real non-zero timestamps and behavior.
railway-app
Bot
temporarily deployed
to
anticapture-infra / anticapture-pr-2168
September 29, 2026 19:47
Destroyed
railway-app
Bot
temporarily deployed
to
anticapture-infra / anticapture-pr-2168
September 30, 2026 18:11
Destroyed
brunod-e
approved these changes
Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Security Council card to the Shutter DAO overview, the same card ENS and Compound already have.
Shutter's veto runs through the new Snapshot X module: the Security Council (5-of-8 Safe
0x3ea7…c0C0) owns the Snapshot X space (0x594E…B769) and vetoes a proposal by callingSpace.cancel(proposalId)any time before execution. The card points at that multisig.Why "No expiration"
Unlike ENS's renewable term or Compound's guardian expiry, Shutter's veto is an owner privilege with no fixed term. This PR adds a
noExpirationflag to thesecurityCouncilconfig: when set, the card shows "No expiration" instead of a countdown and drops the progress/danger bar. ENS and Compound are untouched — they keep theirexpirationblocks and existing behavior.Changes
shared/dao-config/shu.ts— add thesecurityCouncilblock (5-of-8,noExpiration: true, Snapshot X veto description; Start = 2026-09-07, when the Council took ownership of the space).shared/dao-config/types.ts— add optionalnoExpiration?: boolean.features/dao-overview/components/SecurityCouncilCard.tsx— treat anoExpirationcouncil as 0 progress / no danger zone.features/dao-overview/components/CountdownDaoInfo.tsx— render "No expiration" instead of a countdown.@anticapture/dashboard: minor).Verification
devis unchanged).shared/dao-config/dao-config.test.ts: 26/26 pass (incl. SHU).Note
Low Risk
Config and DAO overview UI only; no changes to auth, on-chain logic, or existing ENS/Compound council configs.
Overview
Adds a Security Council block to the Shutter DAO overview config: active 5-of-8 multisig, Safe link, and tooltip text describing Snapshot X
Space.cancelveto (not timelock cancel). Shutter usesnoExpiration: truebecause veto is an open-ended owner privilege; only the council start date (2026-09-07) is meaningful.Introduces optional
noExpirationonsecurityCouncilin shared types.CountdownDaoInforenders "No expiration" instead of a live countdown when that flag is set.SecurityCouncilCardskips term progress and danger-zone math for those councils (0% progress / no warning). ENS and Compound configs are unchanged.Dashboard minor changeset for the new Shutter card behavior.
Reviewed by Cursor Bugbot for commit ac8e8a0. Configure here.