Skip to content

fix(dashboard): fix voter copy button overlap and clipped link column in votes table - #2173

Merged
alextnetto merged 1 commit into
mainfrom
fix/votes-table-spacing
Oct 21, 2026
Merged

alextnetto merged 1 commit into
mainfrom
fix/votes-table-spacing

Conversation

@alextnetto

Copy link
Copy Markdown
Member

Summary

Two spacing problems in the proposal votes table (e.g. ENS proposal 519157…6762, Votes tab):

  1. Copy button overlapping the vote icon. Long ENS names (andreashofmann.eth, ens.garypalmerjr.eth) are wider than the 200px Voter column. The avatar button had no min-w-0, so the name never truncated and the copy button spilled ~7px into the Choice column, touching the For/Against icon. The avatar button now shrinks (the name already has truncate) and the copy button is shrink-0. Same fix in the Didn't vote tab, which uses the identical cell.
  2. Link icon flush against the right edge. The column sizes summed to 800px, but the table container is at most ~792px wide, so the table always overflowed by 8px and the last column was clipped. Choice goes from 120 to 100px (widest content, "Against", needs 91px) and the link column from 40 to 48px, aligned right with 16px right padding. Total is now 788px, so the table fits without horizontal overflow.

Measurements (live page at 1920px, styles applied in the browser)

Before After
Table overflow 8px 0px
Smallest gap copy button → vote icon -7px 16px
Link icon → right border clipped 21px

Test plan

  • prettier --check and eslint pass on both edited files
  • Verified the layout on the live ENS proposal by applying the same styles in the browser

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
anticapture-storybook Ready Ready Preview Oct 20, 2026 2:19pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
anticapture Ignored Ignored Oct 20, 2026 2:19pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T14:20:18.835908Z a7e1e5b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Collaborator

🎨 UI Review

Automated review · ℹ️ Reviewed without a Figma reference — no Figma/spec link in the PR body or ClickUp. The only Vercel preview on the PR is Storybook (the dashboard deploy was ignored), so nothing was checked visually in the live app; findings are grounded in the diff + UX-expert evaluation.


Proposal → Votes tab (TabsVotedContent.tsx)

Must-fix

  • None. Copy button is now shrink-0 and the avatar button min-w-0, so long ENS names truncate instead of pushing the copy icon into Choice. The skeleton row for the link column got the same justify-end py-2 pl-2 pr-4 as the real cell, so loading → loaded doesn't shift.

Nice-to-have

  • Choice column is now 100px with "Against" needing ~91px (per the PR body), so only ~9px of slack. Any wider label or font fallback will clip it. Consider 104–108px and take the difference from another column, keeping the total under the ~792px container. (TabsVotedContent.tsx:207) [UX-heuristic]
  • Truncated voter names have no way to see the full value (no tooltip/title). Users can't tell ens.garypalmerjr.eth from a similar name once it ends in an ellipsis. Add a tooltip with the full name on the avatar button. (TabsVotedContent.tsx:176) [UX-heuristic]

Proposal → Didn't vote tab (TabsDidntVoteContent.tsx)

  • Same min-w-0 / shrink-0 change as Votes; consistent, nothing to flag. The same tooltip suggestion applies. [UX-heuristic]

Mobile

  • Column total is 788px, so the table still scrolls horizontally on small viewports (unchanged). Make sure the tx-link column's pr-4 isn't cut off at the end of the scroll — worth a check on a ≤390px device, since I couldn't load the preview. [UX-heuristic]

Generated by Claude Code

@railway-app
railway-app Bot temporarily deployed to anticapture-infra / anticapture-pr-2173 October 20, 2026 14:19 Destroyed
@railway-app

railway-app Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the anticapture-pr-2173 environment in anticapture-infra

Service Status Web Updated
compound-indexer-offchain ✅ Success (View Logs) Oct 20, 2026 at 8:11 pm UTC
uniswap-indexer-offchain ✅ Success (View Logs) Oct 20, 2026 at 7:41 pm UTC
shutter-indexer-offchain ✅ Success (View Logs) Oct 20, 2026 at 7:40 pm UTC
ens-indexer-offchain ✅ Success (View Logs) Oct 20, 2026 at 7:34 pm UTC
nodeful 🚨 Crashed (View Logs) Oct 20, 2026 at 7:33 pm UTC
gitcoin-indexer-offchain ✅ Success (View Logs) Oct 20, 2026 at 7:31 pm UTC
prometheus ✅ Success (View Logs) Oct 20, 2026 at 3:30 pm UTC
grafana ✅ Success (View Logs) Web Oct 20, 2026 at 3:29 pm UTC
mcp ✅ Success (View Logs) Web Oct 20, 2026 at 2:34 pm UTC
docs ✅ Success (View Logs) Web Oct 20, 2026 at 2:33 pm UTC
gateful ✅ Success (View Logs) Web Oct 20, 2026 at 2:33 pm UTC
address-enrichment ✅ Success (View Logs) Web Oct 20, 2026 at 2:32 pm UTC
gitcoin-api ✅ Success (View Logs) Oct 20, 2026 at 2:32 pm UTC
obol-api ✅ Success (View Logs) Oct 20, 2026 at 2:31 pm UTC
aave-api ✅ Success (View Logs) Oct 20, 2026 at 2:31 pm UTC
fluid-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:31 pm UTC
nouns-api ✅ Success (View Logs) Oct 20, 2026 at 2:31 pm UTC
tornado-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:31 pm UTC
lil-nouns-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:31 pm UTC
shutter-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:31 pm UTC
uniswap-api ✅ Success (View Logs) Oct 20, 2026 at 2:30 pm UTC
otelcol ✅ Success (View Logs) Oct 20, 2026 at 2:30 pm UTC
tempo ✅ Success (View Logs) Oct 20, 2026 at 2:29 pm UTC
lil-nouns-api ✅ Success (View Logs) Oct 20, 2026 at 2:29 pm UTC
shutter-api ✅ Success (View Logs) Oct 20, 2026 at 2:29 pm UTC
scroll-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:29 pm UTC
ens-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:29 pm UTC
obol-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:29 pm UTC
scroll-api ✅ Success (View Logs) Oct 20, 2026 at 2:28 pm UTC
aave-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:28 pm UTC
ens-api ✅ Success (View Logs) Oct 20, 2026 at 2:28 pm UTC
compound-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:28 pm UTC
fluid-api ✅ Success (View Logs) Oct 20, 2026 at 2:28 pm UTC
uniswap-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:27 pm UTC
nouns-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:27 pm UTC
gitcoin-indexer ✅ Success (View Logs) Oct 20, 2026 at 2:27 pm UTC
tornado-api ✅ Success (View Logs) Oct 20, 2026 at 2:27 pm UTC
compound-api ✅ Success (View Logs) Oct 20, 2026 at 2:27 pm UTC
ens-relayer ✅ Success (View Logs) Oct 20, 2026 at 2:27 pm UTC
erpc ✅ Success (View Logs) Oct 20, 2026 at 2:27 pm UTC
user-api ✅ Success (View Logs) Web Oct 20, 2026 at 2:26 pm UTC
alertmanager ✅ Success (View Logs) Web Oct 20, 2026 at 2:25 pm UTC
authful ✅ Success (View Logs) Web Oct 20, 2026 at 2:24 pm UTC
loki ✅ Success (View Logs) Oct 20, 2026 at 2:22 pm UTC

@alextnetto
alextnetto merged commit e09f9d1 into main Oct 21, 2026
59 of 61 checks passed
@alextnetto
alextnetto deleted the fix/votes-table-spacing branch October 21, 2026 11:36

This branch was successfully deployed

1 active deployment
Preview – anticapture-storybook — a7e1e5b2 Deployed Oct 20, 2026 by vercel[bot]
anticapture-infra / anticapture-pr-2173 — a7e1e5b2 Deployed Oct 20, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants