Fix[ntcd_machine]: data corruption and out-of-bounds write - #417
Merged
Merged
Conversation
Added a test function to verify receiving data into a string with spare capacity.
678098
commented
Sep 18, 2026
Avoid data corruption by resizing a buffer before writing to it. Changed 'position' to a constant for clarity and safety. Removed redundant resize call on 'data'.
678098
changed the title
verifyReceiveIntoString test function
678098
commented
Sep 18, 2026
678098
commented
Sep 18, 2026
mattrm456
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bsl::stringinntcd::Packet::dequeueData