Conversation
Mission Control's Spaces Bar draws one button per Space including fullscreen ones, but Reconciler.resolve excludes fullscreen Spaces from userIndex. Since desktop buttons are numbered by structural left-to-right position, userIndex-keyed lookups drift out of sync the moment a display has any fullscreen Space, mislabeling every subsequent button. Reconciler already exposes stripIndex (added in #66 for SwitchPlanner's hop counting) — the 0-based strip position that does count fullscreen tiles. Switch MissionControlOverlayGeometry.spacesByDisplayAndIndex and MissionControlRowResolution.resolve to key on stripIndex instead, so a structural button number maps to the correct nameable Space (or correctly misses, if it lands on a fullscreen tile itself). Closes #65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconciler.resolveexcludes fullscreen Spaces fromuserIndex, so the two diverge the moment a display has any fullscreen Space, mislabeling every button after it.Reconcileralready exposesstripIndex(added in Fix fullscreen switching, correct release docs, and enforce the CI lint gate #66 forSwitchPlanner's hop counting) — the 0-based strip position that does count fullscreen tiles, i.e. exactly the coordinate Mission Control's own button numbering uses.MissionControlOverlayGeometry.spacesByDisplayAndIndexandMissionControlRowResolution.resolvenow key their (display, structural-button-index) →ResolvedSpacelookup bystripIndexinstead ofuserIndex. A structural button landing on a fullscreen tile itself now correctly misses the lookup instead of mislabeling the next nameable Space.stripIndex, an already-shipped, already-tested structural coordinate).Closes #65
Test plan
swift buildswift test(243 tests, 0 failures)xcrun swift-format lint -s -r Sources Tests(clean, matches CI's lint gate)[Desktop 1, fullscreen, Desktop 2]fixture in bothMissionControlOverlayGeometryTestsandMissionControlRowResolutionTests