fix(frontend): resolve 13 defects from the mini app QA check - #73
Merged
Merged
Conversation
Back navigation: the MAX back button is shared by every registered handler, so an open sheet closes first on root screens too, and closing it keeps the screen's button. Finishing onboarding starts a new app history, so Back on a linked venue goes to the catalog. A QR that closes itself after redemption leaves one history entry. Offline: mutations use networkMode "always" and fail at once instead of pausing and replaying later, so a booking is never cancelled without a new confirmation. The test query client now reuses the production defaults. Location buttons in the profile are disabled offline. Bookings: a double tap sends one request, and booking_exists opens the active booking of the item with wording that fits menu items too. Diary: text and photo get their own unrecognised and not food texts. The logged panel closes when its last meal is deleted. The description is kept until it is logged and can be retried. After a lost response the diary is checked before any retry, for the manual form, text and photo, so a saved meal is not added twice. What to eat: "Показать другие" says when no new dishes are left, the "Уточнить" button no longer shrinks, and deal countdowns and closing hours update live, hiding cards that are no longer available. Closes #66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 13 defects from the mini app QA check of build 8c61b1e (3 critical: 5.3, 5.4, 8.2). Row numbers match the report. The same source-blind panel as in 2.6 also showed "На фото не нашли еду" for a
not_foodtext answer, fixed together.Closes #66
Changes
useBackButtoninsrc/max/bridge.tskeeps one MAX subscription and a stack of handlers: the latest one runs, the button hides only when none is left.BottomSheetregisterscloseTopSheetwhile open, so Back closes a sheet on root screens and closing it keeps the screen's button.useResetHistoryinsrc/shared/appHistory.ts;DoneStepstarts a new app history, so Back on a linked venue goes to its parent instead of the onboarding steps.networkMode: 'always'and fail at once offline, nothing is replayed on reconnect; queries still pause and refetch.test/app.tsxreusescreateQueryClientfromRoot.tsx. Profile location buttons are disabled offline.booking_existsopens the active booking of the item, fallback text fits menu items.navigate(-1)when the booking resolves, one Back leaves the booking.flex-shrink: 0), checked at 390 px in headless Chrome.useNow; countdowns tick and cards with an ended deal or a closed venue are hidden.docs/max-features.mdand README describeBackButtonon open panels.Testing
npm run lint,npm run typecheckandnpm testpass locally (frontend: 531 tests,npm run buildpasses; backendsrc/docs.test.tspasses)Not covered here, needs a phone: the MAX side of 4.2, 6 and 7 from the report.