Skip to content

feat: add loadingBuilder support for PhotoViewGalleryPageOptions #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linchen00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add loadingBuilder support for PhotoViewGalleryPageOptions #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/photo_view_gallery.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class _PhotoViewGalleryState extends State<PhotoViewGallery> {
: PhotoView(
key: ObjectKey(index),
imageProvider: pageOption.imageProvider,
loadingBuilder: widget.loadingBuilder,
loadingBuilder: pageOption.loadingBuilder ?? widget.loadingBuilder,
backgroundDecoration: widget.backgroundDecoration,
wantKeepAlive: widget.wantKeepAlive,
controller: pageOption.controller,
Expand Down Expand Up @@ -343,6 +343,7 @@ class PhotoViewGalleryPageOptions {
this.tightMode,
this.filterQuality,
this.disableGestures,
this.loadingBuilder,
this.errorBuilder,
}) : child = null,
childSize = null,
Expand All @@ -367,7 +368,8 @@ class PhotoViewGalleryPageOptions {
this.tightMode,
this.filterQuality,
this.disableGestures,
}) : errorBuilder = null,
}) : loadingBuilder = null,
errorBuilder = null,
imageProvider = null;

/// Mirror to [PhotoView.imageProvider]
Expand Down Expand Up @@ -427,6 +429,8 @@ class PhotoViewGalleryPageOptions {
/// Quality levels for image filters.
final FilterQuality? filterQuality;

final LoadingBuilder? loadingBuilder;

/// Mirror to [PhotoView.errorBuilder]
final ImageErrorWidgetBuilder? errorBuilder;
}