Repository navigation
Migrate desktop to TypeScript and Oxc; bundle the refreshed guide - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the Electron wrapper, Forge configuration, and build/test tools to strict TypeScript, replace ESLint/Prettier with oxlint/oxfmt, and require Node.js 24+. Bundle the full Food Guide migration and interface refresh through the updated
app/foodguidesubmodule.Desktop implementation
src/intodist/; usedist/index.cjsas the runtime entrypoint. Starting, testing, asset generation, packaging, and making distributables build the wrapper and embedded guide first.Bundled guide changes
The companion Food Guide PR #87 contains the detailed implementation and validation summary. This pin includes the whole branch, including:
Merge order
Merge Food Guide PR #87 first. The desktop submodule currently pins
157ea288ba194ca28be6ecac9bf3928b71b3eae7. If the guide is squash-merged or rebased, repinapp/foodguideto the resulting commit on guidemainand rerun desktop checks before merging this PR. A guide merge commit preserves the existing pin.Validation
npm run checkpasses: 32 wrapper tests (31 pass; one Windows-specific test skipped on Linux), 193 embedded guide unit tests, lint, format, and strict wrapper/Forge/guide type checks.