[TEST — DO NOT MERGE] verify diff-scoping skip path#14
Closed
bluejayA wants to merge 3 commits into
Closed
Conversation
Large plugin updates were timing out because every skill in the plugin was re-audited even when only a few actually changed. Use the old/new revision pair from marketplace.json to `git diff` the plugin repo and audit only the skills whose files changed. Shared-path (`skills/_*`) changes fall back to a full audit to preserve correctness. Also add a 300s per-skill timeout so a single hung audit cannot stall the job. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…COPE_KIND enum
Applying reviewer feedback on the diff-scoping patch:
- Validate `revision` / `old_revision` fields as `^[a-f0-9]{7,40}$`
before they reach `git fetch` / `git diff` (defense-in-depth).
- Tighten awk path filter from `NF>=2` to `NF>=3` so that files sitting
directly under `skills/` (e.g. `skills/README.md`) no longer pollute
`CHANGED_DIRS` or `SHARED_CHANGED` detection.
- Split `SCOPE_MODE` into `SCOPE_KIND` (enum for control flow) and
`SCOPE_DESC` (human-readable label). The old string was used for both,
so any future label tweak would silently break the full-fallback
branch. Comparisons now use the enum only.
- Convert `cmd && A || B` DIFF_OK assignment to `if/then/else` for
readability.
- Replace `wc -l | tr -d ' '` skill count with `grep -c .` for correct
handling of trailing-newline-less input.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…path Bump skill-security-audit revision from 8b31698 to 2cbdfb8. The two commits in between (add docsd/ + revert) cancel out so `git diff 8b31698..2cbdfb8 -- skills/` is empty. The new workflow should short-circuit to "No skill code changes detected — audit skipped" without calling the Claude CLI. Do NOT merge — this PR exists only to exercise the diff-scoping logic on feat/remote-audit-scope-by-diff. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
✅ Skill Audit Results (Remote Plugin)Verdict: PASSED ℹ️ skill-security-auditNo skill code changes detected in 8b31698..2cbdfb8 — audit skipped. |
Owner
Author
|
Verification complete — diff-scoping short-circuit works as designed (9s runtime, 0 Claude CLI calls, correct skip message). Closing and cleaning up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이 PR은 #13의 diff-scoping 로직을 실 환경에서 검증하기 위한 테스트 전용입니다.
테스트 브랜치는
feat/remote-audit-scope-by-diff에서 파생되었으므로 PR head에 이미 새 워크플로우가 포함되어 있습니다 — GHA는 PR head의 워크플로우를 실행하므로 즉시 새 로직이 동작합니다.설정
skill-security-auditrevision:8b31698→2cbdfb8git diff 8b31698..2cbdfb8 -- skills/= empty기대 동작
Validate revision SHAs단계 통과 (둘 다 유효한 hex SHA)Audit scope: diff (8b31698..2cbdfb8)로그No skill code changes detected in 8b31698..2cbdfb8 — audit skippednoticeTest plan
test/verify-diff-scoping브랜치 삭제