Repository navigation
Conversation
A partial uid lookup used Like on the start.uid metadata field, which no index can serve, so it scanned every run in the catalog. A run's node key is its uid, so match on the key with KeyLike instead, which uses the catalog's key column. Closes bluesky#79. Fall back to Like when the server does not advertise the key_like query: such a server silently ignores the filter and returns every run. Require tiled >=0.2.22, which introduces KeyLike. CatalogOfBlueskyRuns.search prefixes a query's key with 'start.' to default to the RunStart document; exempt KeyLike and KeyLookup, whose key is the node key, not a metadata path.
danielballan
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial uid lookup used Like on the start.uid metadata field, which no index can serve, so it scanned every run in the catalog. A run's node key is its uid, so match on the key with KeyLike instead, which uses the catalog's key column. Closes #79.
Fall back to Like when the server does not advertise the key_like query: such a server silently ignores the filter and returns every run. Require tiled >=0.2.22, which introduces KeyLike.