Repository navigation
Make AsyncMovable.set value parameter positional-only - #1477
Open
jacopoabramo wants to merge 3 commits into
Open
jacopoabramo wants to merge 3 commits into
jacopoabramo wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if it's intentional, but
AsyncMovable.setis misaligned frombluesky.protocols.Movable, because the latter accepts only positional arguments while the former doesn't have that kind of limitation.This keeps the two protocols conformant while allowing set to accept also keyword arguments (I believe
StandardMovable.sethas a timeout keyword parameter)I spotted this inconsistency in my own project and it forced me to override the set method with a different signature. This helps keeping consistency when using
AsyncMovablecompatible devices with bluesky plans requiringMovableobjects.