Repository navigation
Conversation
adcore.plugins_with_proc() builds the "proc" plugin from proc_suffix and adds it to a detector's plugins, rejecting a "proc" passed in plugins. The seven vendor detectors (Andor2, Aravis, Kinetix, Merlin, Pilatus, SimDetector, Vimba) and ContAcqDetector use it and pass the process plugin to their trigger logic as before. Includes the changelog entry, the how-to line and the test for the reserved name. Assisted-by: Claude Opus 5.5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New public
adcore.plugins_with_proc()builds the"proc"plugin fromproc_suffix, adds it to a detector'splugins, and raisesValueErrorifpluginsalready has a"proc".ContAcqDetectoruse it, and pass the process plugin to their trigger logic as before.Changes
"proc"is reserved in a vendor detector'splugins: passproc_suffixinstead.How to review
Start with
epics/adcore/_detector.pyforplugins_with_proc(). The vendor detector changes are the same mechanical edit repeated.AI Disclaimer
The code and this description were generated with AI and reviewed/tweaked by the author.