Skip to content

Speed up profile selection handoff #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blurbery wants to merge 1 commit into
base: upstream-review/main
Choose a base branch
from
+6 −3
Open

Speed up profile selection handoff #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iosApp/iosApp/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,8 +887,8 @@ struct ContentView: View {
requiresPIN: profile.hasPin
)
StartupContentPrefetcher.prefetchAuthenticatedContent()
await PlayerSettings.shared.refreshFromServer()
router.resetToHome()
await PlayerSettings.shared.refreshFromServer()
print("[DebugAutoLogin] signed in and selected profile")
} catch {
print("[DebugAutoLogin] failed: \(error)")
Expand Down
7 changes: 5 additions & 2 deletions iosApp/iosApp/Screens/Profiles/ProfileSelectionViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,11 @@ class ProfileSelectionViewModel {
requiresPIN: profile.hasPin
)
StartupContentPrefetcher.prefetchAuthenticatedContent()
await PlayerSettings.shared.refreshFromServer()
// Change screens before the settings request suspends. The refresh
// applies this profile's cached playback quality synchronously,
// then updates it from the server while Home is already visible.
router.resetToHome()
await PlayerSettings.shared.refreshFromServer()
} catch {
self.error = ErrorState(error)
}
Expand All @@ -77,8 +80,8 @@ class ProfileSelectionViewModel {
requiresPIN: profile.hasPin
)
StartupContentPrefetcher.prefetchAuthenticatedContent()
await PlayerSettings.shared.refreshFromServer()
router.resetToHome()
await PlayerSettings.shared.refreshFromServer()
}

/// The picker itself has no active profile, but the server requires the
Expand Down