Fix swapchain semaphore reuse validation warning#59
Open
sammifs wants to merge 1 commit into
Open
Conversation
…ores per swapchain image Use a separate semaphore for each swapchain image instead of reusing present-wait semaphores per frame in flight. Signal and present using readyPresentSemaphores[imageIndex] so a semaphore is only reused after its swapchain image has been reacquired. Also rename renderFinishedSemaphores to readyPresentSemaphores for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attempted fix for a repeating Vulkan validation warning caused by reusing the semaphore passed to
vkQueuePresentKHRas a per-frame resource instead of a per-swapchain-image resource.This change updates the present-ready semaphores to be allocated per swapchain image and indexed by the acquired image index, I really tried to follow and understand the guidance here:
https://docs.vulkan.org/guide/latest/swapchain_semaphore_reuse.html
I still can not claim any expertise in these concepts/structures, but by following the page above and the example fix commit they linked to I got the warning to disappear. Compiles and runs and I cant spot anything amiss.
Problem
Running the current
mainproduces the following repeating validation warning (memory addresses/ image indices vary of course):