Skip to content

[codex] fix door send_output callback - #183

Merged
bmanturner merged 1 commit into
mainfrom
codex/fix-door-send-output-callback
May 19, 2026
Merged

bmanturner merged 1 commit into
mainfrom
codex/fix-door-send-output-callback

Conversation

@bmanturner

Copy link
Copy Markdown
Owner

Summary

  • restore the native door send_output callback contract to return :ok
  • add a regression door that pattern-matches on send_output returning :ok

Root Cause

Commit 03a6bb5 changed Runner.emit/2 to return updated runner state for UTF-8 buffering, but launch_context/1 still exposed that internal return value through send_output.

Validation

  • rtk mix test test/foglet_bbs/doors/runner_test.exs:42 test/foglet_bbs/doors/output_encoding_test.exs test/foglet_bbs/doors_test.exs
  • rtk python3 test/priv/doors/pty/foglet_pty_adapter_test.py
  • rtk mix precommit

@bmanturner
bmanturner marked this pull request as ready for review May 19, 2026 22:45
@bmanturner
bmanturner force-pushed the codex/fix-door-send-output-callback branch from 906d4ed to c191fe6 Compare May 19, 2026 22:45
@bmanturner
bmanturner merged commit 038685c into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant