Skip to content

fix: handle board activity broadcast returns - #185

Merged
bmanturner merged 4 commits into
mainfrom
fix/board-activity-broadcast-returns
May 25, 2026
Merged

bmanturner merged 4 commits into
mainfrom
fix/board-activity-broadcast-returns

Conversation

@bmanturner

Copy link
Copy Markdown
Owner

Summary

This PR contains the final fix from the perfect-QA loop and the already-pushed QA harness stabilization / residual live-update coverage work now on the clean review branch.

What changed

  • Stabilized the multi-session SSH/TUI harness authentication path so live multi-user sessions can reliably authenticate in automated QA.
  • Added residual live-update coverage for board-directory activity paths, including board/category/subscription/read-pointer events exercised through the QA suite.
  • Fixed the final Dialyzer issue found during the closing QA loop: board activity PubSub broadcasts returned :ok | {:error, _} and several callers ignored that return value implicitly.
  • Updated lib/foglet_bbs/boards.ex so board creation, subscribe/unsubscribe, read-pointer advancement, and board-directory result tapping explicitly discard broadcast results where failure should not change the domain operation result.

Why this matters

The product behavior was already passing runtime QA, but the final precommit loop exposed static-analysis noise that would keep the branch from being a clean review artifact. This PR makes the branch reviewable: the live SSH/TUI evidence passes, the automated suite passes, and the precommit gate is green locally.

Verification

Local verification run after the final fix:

  • rtk mix test — 3336 tests, 3 properties, 0 failures
  • rtk npm install — clean, 0 vulnerabilities
  • rtk npm run --silent test:ssh-harness — pass
  • Live SSH/TUI multi-session suite against a fresh DB/runtime — 9/9 scenarios pass, including the real 75s ephemeral TTL wait
  • rtk mix precommit — pass: compile, dependency unlock check, format, Credo strict, Sobelow, Dialyzer

Evidence archive generated locally:

  • /tmp/foglet-perfect-qa-20260519-221921.tgz
  • SHA256: dd3e09a4cc62c8728908cbeb2b20debb1a57494fce67c37a6d5ad6c3f813469d

Notes

  • No GitHub issue identifiers are included in the branch, title, or PR description.
  • The original QA branch remains pushed for Paperclip traceability, but this PR uses a clean branch name for review.

@bmanturner
bmanturner merged commit 45d7161 into main May 25, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant