Repository navigation
fix: handle board activity broadcast returns - #185
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the final fix from the perfect-QA loop and the already-pushed QA harness stabilization / residual live-update coverage work now on the clean review branch.
What changed
:ok | {:error, _}and several callers ignored that return value implicitly.lib/foglet_bbs/boards.exso board creation, subscribe/unsubscribe, read-pointer advancement, and board-directory result tapping explicitly discard broadcast results where failure should not change the domain operation result.Why this matters
The product behavior was already passing runtime QA, but the final precommit loop exposed static-analysis noise that would keep the branch from being a clean review artifact. This PR makes the branch reviewable: the live SSH/TUI evidence passes, the automated suite passes, and the precommit gate is green locally.
Verification
Local verification run after the final fix:
rtk mix test— 3336 tests, 3 properties, 0 failuresrtk npm install— clean, 0 vulnerabilitiesrtk npm run --silent test:ssh-harness— passrtk mix precommit— pass: compile, dependency unlock check, format, Credo strict, Sobelow, DialyzerEvidence archive generated locally:
/tmp/foglet-perfect-qa-20260519-221921.tgzdd3e09a4cc62c8728908cbeb2b20debb1a57494fce67c37a6d5ad6c3f813469dNotes