You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coq 8.7 shall come with a fix to decide equality which makes it working better (even though more progresses are expectable). However, this improvement breaks topology.
The attached patch allows to compile topology with 8.7. However, the fix is not compatible with 8.6. May I let you decide if you prefer preparing your own patch so as to be compatible over both 8.6 and 8.7 at the same time, or whether you prefer to have disjoint versions.
Note that we can also provide various different ways to support compatibility over different versions. For instance, the question of possibly providing Set Version 8.6./Unset Version 8.6. commands around parts of code that would work only in 8.6 has been considered, though no final decision has been taken yet. Don't hesitate to tell your point of view as a user, if you have one.
Thanks! I'll try to take a look at this in the coming days. I think I will just use decidable quality explicitly in the cases where it works in both 8.6 and 8.7 and use the manual derivation elsewhere (rather than just using try).
I made a small change with commit c7bccde to just stop using the decidable equality tactic. Apparently on 8.6 it was only solving decidable equality on False, which I can easily do myself! This should work for both 8.6 and 8.7, but I haven't gotten the chance to test with the latest version of coq-dev. The build with coq-dev is erroring in Travis CI, I think due to a failure to install CoRN, so I can't tell. But this seems like a safe change and ought to allow compilation on both 8.6 and 8.7.
As a note, I believe that the branch that you're tracking is ci, rather than master. Once I get evidence that I didn't break things with this change, I'll incorporate the change into ci so it works for you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Coq 8.7 shall come with a fix to
decide equalitywhich makes it working better (even though more progresses are expectable). However, this improvement breakstopology.The attached patch allows to compile
topologywith 8.7. However, the fix is not compatible with 8.6. May I let you decide if you prefer preparing your own patch so as to be compatible over both 8.6 and 8.7 at the same time, or whether you prefer to have disjoint versions.Note that we can also provide various different ways to support compatibility over different versions. For instance, the question of possibly providing
Set Version 8.6./Unset Version 8.6.commands around parts of code that would work only in 8.6 has been considered, though no final decision has been taken yet. Don't hesitate to tell your point of view as a user, if you have one.