spike on the graph based check#147
Closed
melodyoncode wants to merge 1 commit into
Closed
Conversation
melodyoncode
force-pushed
the
spike_graph_based_check
branch
3 times, most recently
from
2d142c0 to
8fb9ec7
Compare
| def can_be_null(self): | ||
| return False | ||
|
|
||
| def update_fields(self, parent): |
There was a problem hiding this comment.
I think the method should have a more presice name
Author
There was a problem hiding this comment.
sure, change to "resolve_optional_fields" might make it more clear.
melodyoncode
force-pushed
the
spike_graph_based_check
branch
2 times, most recently
from
611c355 to
143819d
Compare
Issue: SWP-207929
melodyoncode
force-pushed
the
spike_graph_based_check
branch
from
143819d to
3ccbd06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
descriptionand resolving them duringresolve_references.