Skip to content

test(compat): mandatory error snapshot assertion#67

Merged
bmwill merged 2 commits into
bmwill:masterfrom
weihanglo:test-infra
Apr 18, 2026
Merged

test(compat): mandatory error snapshot assertion#67
bmwill merged 2 commits into
bmwill:masterfrom
weihanglo:test-infra

Conversation

@weihanglo

Copy link
Copy Markdown
Contributor

This ensures we see the expected error,
not unrelated random one.

I expect external tools won't update error messages too often,
otherwise it may cause churns

@weihanglo

Copy link
Copy Markdown
Contributor Author

Forgot to say, this is a preparation so we can see the exact error message from git apply failure when applying control=0, rather than some other random binary diff parsing failure.
(I spent quite a while to find my control=0 patch fixture has some other issues 😓)

@bmwill
bmwill merged commit a41dd00 into bmwill:master Apr 18, 2026
18 checks passed
@weihanglo
weihanglo deleted the test-infra branch April 18, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants