Add CTM comparison site test cases (pricing, ranking, errors, flags)#6
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Add CTM comparison site test cases (pricing, ranking, errors, flags)#6devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a single comprehensive review-ready test-case markdown file for the comparison-site backend. No production code, requirements docs, existing feature files, or
application.ymlwere modified — this PR only adds one new file underdocs/test-cases/.Scope covered:
DefaultPricingEngine) — age, mileage, car-value, claims factors; deterministic seeded ±2% noise;monthly = round(annual / 12 × 1.05)DefaultRankingService(price 50% / rating 30% / features 20%) vsExperimentalRankingService(price 30% / rating 35% / features 15% / value-for-money 20%);isBestPriceandisRecommendedflags; score normalization 0–1GlobalExceptionHandler) —MethodArgumentNotValidException→ 400,ConstraintViolationException→ 400, genericException→ 500; all includetimestamp; no stack traces leakexperimental-rankingtoggle,map-enabledtoggle, health check endpoint; admin endpoint protection (BACKLOG #16) gap documentedOutput file:
docs/test-cases/ctm-comparison-test-cases.mdTotal test cases: 115
TC-QUOTE-NNN)TC-PRICING-NNN)TC-RANK-NNN)TC-ERR-NNN)TC-FLAG-NNN)Every age / mileage / car-value bracket boundary is covered with TWO test cases (one each side of the threshold), per the scope:
The file follows the spec layout: title + summary, scope/traceability table, coverage matrix, BDD
gherkinscenarios with proper tags (@positive/@negative/@boundary/@exception/@securityplus suite tags@smoke/@regression/@criticaland feature-area tags@quote/@pricing/@ranking/@error-handling/@feature-flag/@admin/@deterministic), traditional tabular section, known defects subsection, and the QA Review Checklist.Known Defects Covered
No explicit
BUG-NNNIDs were assigned in this scope. Documented BACKLOG gaps that have explicit security/regression coverage:TC-FLAG-014andTC-FLAG-015(security; flagged as documented gap with current vs expected behavior)TC-QUOTE-026(XSS payload rejection at validation)Review & Testing Checklist for Human
AC-Q-001..005,AC-R-001..003,AC-E-001..004,AC-F-001..006,BR-PRICE-*,BR-RANK-*,BR-SEC-*)DefaultPricingEnginesource to confirm interpretation matches (e.g., age 21 → 1.5, mileage 5001 → 0.9, car value 5000 → 1.0)Notes
docs/test-cases/ctm-comparison-test-cases.mdapplication.ymlwere modifiedLink to Devin session: https://bobby-demo.devinenterprise.com/sessions/ec923b7b585344ddaf2119e5d60e5767
Requested by: @bsmitches