Fix workbench scenario lifecycle guards - #19
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
This PR leaves an unsynchronized unsaved-scenario refresh path that can report a successful newer operation as a failure and lose a newly saved scenario; please address before merging.
Reviewed changes This review covers scenario lifecycle guards, unsaved and empty-workbench transitions, scenario-browser action gating, and workspace bootstrap result propagation.
- Scenario transitions Tracks the scenario opened before an unsaved draft and adds an Exit action that restores it or refreshes the workspace.
- Empty workbench Adds a blank state when examples are hidden and no local scenario is available, with a restore action.
- Interaction guards Blocks scenario selection, removal, import, and example dismissal during runs, file operations, loading, and historical read-only mode.
- Refresh outcomes Makes workspace bootstrap report success and surfaces removal and Exit refresh failures.
- Save feedback Adds an accessible interactive multiline tooltip explaining why Save as is unavailable.
GPT Luna | 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes This incremental review covers the refresh-race fixes added since the previous Pullfrog review.
- Distinguished refresh outcomes Separated successful, failed, and superseded workspace bootstrap requests so stale results do not surface as failures.
- Serialized unsaved exits Prevented repeated Exit refreshes and ignored superseded results during unsaved-scenario recovery.
- Extended lifecycle guards Propagated catalog-loading state to Save as and scenario browser actions, and handled superseded removal refreshes without reporting false failures.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
Broad lifecycle/integration coverage remains intentionally deferred. Generated build and mode-only changes were excluded from the commit.