W5b-15: two cleanups on main - #56
Merged
Merged
Conversation
1. reconcile_case_constraints takes a REQUIRED positional CompiledConstraints — the None branch with the lazy inline compile_constraints() fallback is deleted (a dual path). The caller (run_parallel_generation) compiles once per request and passes the compiled object through. 2. No coder handles in the public repo: 8 hits rewritten (CHANGELOG.md, tests/test_timing.py, tests/test_engine.py, engine.py x3, timing.py x2) to describe the work without the handle; coordination-only phrasing dropped. 669 passed, 21 deselected; ruff check + format clean.
bnsd55
added a commit
that referenced
this pull request
Sep 19, 2026
…rejection, one-shape fixtures - restore the module-level CompiledConstraints import (NAMELY: #49/#56 made it required at runtime, my TYPE_CHECKING-only rebase dropped it) - CalibrationBundle.from_payload now REJECTS the retired top-level-temperature shape loudly (stale files half-loading is worse than failing) - one-shape fixtures across test_multi / test_cli_smoke / test_w2e_calib - 726 passed, ruff clean
bnsd55
added a commit
that referenced
this pull request
Sep 19, 2026
…rejection, one-shape fixtures - restore the module-level CompiledConstraints import (NAMELY: #49/#56 made it required at runtime, my TYPE_CHECKING-only rebase dropped it) - CalibrationBundle.from_payload now REJECTS the retired top-level-temperature shape loudly (stale files half-loading is worse than failing) - one-shape fixtures across test_multi / test_cli_smoke / test_w2e_calib - 726 passed, ruff clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from #50, minimal diff (coder3 is rebasing #51 in the multi block):
reconcile_case_constraints takes a REQUIRED positional
CompiledConstraints— theNonebranch with the lazy inlinecompile_constraints()fallback is deleted (a dual path). The caller (run_parallel_generation) compiles once per request and passes the compiled object through.No handles in the public repo — all 8
coder[0-9]hits rewritten (CHANGELOG.md, tests/test_timing.py, tests/test_engine.py, engine.py ×3, timing.py ×2) to describe the work without the handle; coordination-only phrasing dropped.git grep -nE 'coder[0-9]' -- '*.py' '*.md'→ 0 hits.669 passed, 21 deselected; ruff check + format clean.