Conversation
…ECTURE/CHANGELOG) - _load_calibration: plain isinstance(calibration, CalibrationBundle); the duck-typing shim (type().__name__ + hasattr surface) is deleted. The module-reload isolation it papered over is fixed at the source: test_check_results no longer evicts jevmlx.calibrate (it is not an mlx dependency; evicting it while jevmlx.engine survives made isinstance stale) - Public signatures (api x4, openai_slots) take str | CalibrationBundle | None ONLY; the dict-payload branches are deleted (a second shape is a dual path). Engine internals (run_parallel_generation, _assemble, run_parallel_generation_batched, _decide_multi_field) take CalibrationBundle | None. No file I/O in the engine. - ARCHITECTURE.md: v8 -> v9 (2 sites); rewritten set-constraints section (exact solver, no syntactic contradiction rules, count+set precedence + dropped_reason, calibration bundle shape + boundary contract, abstention Optional rule, decision_margin contract) - CHANGELOG: W5-C Unreleased entry - 757 passed (random + no:randomly), .venv/bin/ruff check + format clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #51 (merged as bb86a3f). Main still carried the duck-typing shim, dict signatures, and pre-W5-C docs.
Changes
test_check_resultsno longer evictsjevmlx.calibrate(not an mlx dependency; evicting it whilejevmlx.enginesurvives made isinstance stale across the suite).str | CalibrationBundle | Noneonly; dict branches deleted. Engine internals takeCalibrationBundle | Noneonly. No file I/O in the engine.Verification
757 passed (random + no:randomly), .venv/bin/ruff check + format clean.