Remove private/internal references from 2026-07-13 - #7
Open
boardwalk-bot[bot] wants to merge 1 commit into
Open
boardwalk-bot[bot] wants to merge 1 commit into
boardwalk-bot[bot] wants to merge 1 commit into
Conversation
Automated remediation for daily private reference scan.
Author
There was a problem hiding this comment.
Automated review: looks good
The diff performs the claimed fixture-only remediation: mock API-key prefixes and demo organization IDs are replaced with generic placeholders, with corresponding assertions updated consistently. No correctness, security, test-coverage, or scope issues are evident in the provided changes.
Findings
No findings.
Posted by the Boardwalk PR reviewer (non-blocking).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated remediation from Boardwalk's daily private reference scan.
Summary: No critical or high-severity leaks found. The commits introduce public-facing functionality (org IDs in whoami/status, branded OAuth callback, workflow search) and include test data with generic placeholders. The only finding is a low-severity signal: test fixtures exposing demo org IDs (01ORGDEMO, 01ORGACME) and a mock API key (bwk_x), which are clearly non-real but should be generalized to avoid any perception of leaking internal ID formats.
Findings addressed:
src/commands/session.test.ts:orgId: "01ORGDEMO"— Replace "01ORGDEMO" with a generic placeholder like "demo-org-id" or "ORG_ID_PLACEHOLDER" to avoid exposing the internal ULID format.src/commands/session.test.ts:token: "bwk_x"— Replace "bwk_x" with "TEST_TOKEN" or "mock_token_value" to avoid exposing the API key prefix format.src/commands/status.test.ts:id: "01ORGDEMO"— Replace "01ORGDEMO" with "demo-org-id" or "ORG_ID_PLACEHOLDER".src/commands/status.test.ts:id: "01ORGACME"— Replace "01ORGACME" with "acme-org-id" or "ORG_ID_PLACEHOLDER_2".Please review carefully before merging. If any finding involved an actual credential, rotate it out-of-band.