Repository navigation
fix: Correct Docker 4.1.6 build failures (TypeScript errors in AgentKeyRequest) - #13
Merged
Merged
Conversation
…nces - Add application_uuid and application_name optional fields to AgentKeyRequest type - Fix application link in _SourcesPage to use applicationPath() helper instead of wrong /application/ route - Fix routes.ts to use connexionsRoute instead of removed servicesRoute (page 'services' was merged into 'connexions' in PR #12) Resolves Docker build failure (astro check TypeScript errors) in Actions run https://github.com/bobdivx/devforge/actions/runs/33009255574 Co-authored-by: Mathieu JESER <bobdivx@users.noreply.github.com>
bobdivx
marked this pull request as ready for review
August 27, 2026 03:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
Docker Images build failed on main (commit ccb767f) due to TypeScript errors in
frontend/src/pages/sources/_SourcesPage.tsx:application_namedoes not exist on typeAgentKeyRequestapplication_uuiddoes not exist on typeAgentKeyRequestapplication_namedoes not exist on typeAgentKeyRequestAdditionally, the build failed with "Route manquante dans appRoutes: services" because PR #12 merged the services page into connexions but left stale references.
✅ Solution
Added missing fields to
AgentKeyRequesttype (frontend/src/lib/api/domain.ts):application_uuid?: string | nullapplication_name?: string | nullFixed application link in connexions hub (
frontend/src/pages/sources/_SourcesPage.tsx):applicationPathhelper from routing module/application/${uuid}with correctapplicationPath(uuid)(canonical route is/applications/<uuid>)Fixed stale
servicesRoutereferences (frontend/src/lib/routing/routes.ts):const servicesRoute = appRouteByPage('services')(page no longer exists after PR feat: Hub de connexions et robustesse API #12 merge)connexionsRoutesince/servicesnow redirects to connexions hub✅ Verification
astro checkreports 0 errors (down from 3)npm run build:frontendcompletes successfully📦 Unblocks
docker/devforge-api,docker/devforge-web)Fixes https://github.com/bobdivx/devforge/actions/runs/33009255574