Repository navigation
[GH-fix] Auto-deploy: stale repair no longer blocks new commits - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The auto-deploy poller (
auto_deploy::deploy_project) skipped a project silently and with no time limit whenever arepaircorrection was open intesting,proposedorconflict. On popcornn-server, a repair has been sitting inproposed("Prête", never applied) since 14/10. So all 4 commits pushed ondevbetween 19:36 and 20:33 UTC were never deployed, and nothing showed it except aninfolog line. They only went out with a manual deploy on 15/10.The GitHub App work (P2/P3) is not involved: app mode is off in prod, and the legacy webhook and resolver paths behave the same as before.
Fix
correction::repair_gate. Only a repair that is actively intestingand was updated less than 30 min ago holds back a new commit.proposed,conflictand staletestingrepairs are archived with a note, and the deploy goes ahead. The draft is still backed up first bybackup_draft_before_reset, as before.warn.Tests
repair_gate_tests(2 tests) pass.