[bobdivx]

🛡️ Sentinel: [CRITICAL] Fix Path Traversal in agent workdir commands

🚨 Severity: CRITICAL
💡 Vulnerability: The validate_read_only function in crates/agent/src/tools/workdir_cmd.rs used a naive BLOCKED_TOKENS blocklist on the raw command string, failing to account for shell argument obfuscation via quotation (e.g., cat ".."/".."). This allowed directory traversal vulnerabilities for ostensibly read-only commands.
🎯 Impact: Attackers could execute read-only commands to traverse directories and read sensitive files outside of the intended scope.
🔧 Fix: Updated the check inside validate_read_only to verify for .. inside the already split and tokenized command arguments, robustly blocking traversal attempts regardless of how they are quoted.
✅ Verification: Ensure tests pass cargo test -p devforge-agent --lib tools::workdir_cmd::tests with the new regression test coverage added for cat ".."/".."/etc/passwd.

---

PR created automatically by Jules for task 10617239769117897158 started by @bobdivx

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.