Skip to content

fix: mise a jour instance via docker.sock sans SSH hote - #34

Closed
bobdivx wants to merge 1 commit into
mainfrom
fix/instance-upgrade-docker-sock
Closed

bobdivx wants to merge 1 commit into
mainfrom
fix/instance-upgrade-docker-sock

Conversation

@bobdivx

@bobdivx bobdivx commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Allow DevForge self-update from the UX on ZimaOS/CasaOS when SSH to host.docker.internal:22 is down.
  • Grant www-data access to the mounted Docker socket at boot (group + ACL).
  • Ship Docker CLI in the API image so local upgrade.sh can talk to the engine.
  • Prefer local docker.sock upgrade; SSH only as secondary fallback.
  • Add Pest coverage for the ZimaOS 660 root:docker socket case.

Why

The UX error about localhost SSH unreachable happened because canRunLocalDockerUpgrade() only checked is_readable() on the socket while PHP runs as www-data.

Test plan

  • ZimaOS: Settings -> Mettre a jour maintenant works without host SSH
  • After boot, www-data in api can run docker info
  • Unit: InstanceUpgradeServiceTest for evaluateLocalDockerUpgrade
  • First jump onto this image may still need a store/pull; later updates via UX only

Grant www-data the docker.sock GID at boot, ship docker CLI in the API image, and probe the engine with docker info so ZimaOS/CasaOS self-update works from the UX.
@bobdivx bobdivx closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant