Repository navigation
fix: ne plus basculer une app Astro SSR vers nginx static - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Le harness
ISSUE_ASTRO_STATIC_RUNTIMEappliquait aveuglémentastroStaticNginxRuntimeSettings()(is_static, nginx:alpine, port 80,/dist) puis redéployait.Conséquence : une app Astro SSR (output server/hybrid,
@astrojs/node,node ./dist/server/entry.mjs, port 4321) se retrouvait servie en static nginx. Le détecteur inférait bienastro-ssr, mais le déploiement utilisait unbuild_pack=staticpérimé en base.Les échecs mux SSH mkdir précédents avaient ensuite poussé le harness à basculer vers static.
Correctifs
ApplicationRuntimeSettingsDetector. Si le framework estastro-ssr(ou signaux SSR : startentry.mjs, port 4321), applique/conserve les réglages nixpacks (is_static=false,build_pack=nixpacks, port 4321,node ./dist/server/entry.mjs, health/status:4321)./statusou un healthcheck fail sur une app SSR connue n'est plus classéISSUE_ASTRO_STATIC_RUNTIME, sauf sientry.mjsest vraiment absent et que le détecteur dit static.build_packstocké vautstatic→nixpacks. Ce reconcile tourne déjà au début dequeue_application_deployment(avant le job), donc le build ne part plus en static nginx.astroSsrNixpacksRuntimeSettings()+ helpers SSR.Tests
AgentDirectivesTest: réglages SSR nixpacks ; nginx/status404 ≠ static ; missing entry +astro-ssr≠ISSUE_ASTRO_STATIC_RUNTIME; missing entry +astro-static= static.ApplicationDeploySettingsReconcilerTest:build_pack=staticstale corrigé versnixpackspour Astro SSR.Le cas harness existant (UUID fictif, pas de ligne Application) continue d'appliquer nginx static.
Version
Pas de bump :
constants.phpest déjà en 4.1.18 (action Hub).versions.jsonsera mis à jour par la CI après merge.Hors scope
Pas de merge ici (attendre la CI). Aucun redeploy starbasefr. Aucune touche ollama / popcornn / zimatools.