Skip to content

Conversation

@Mike4U
Copy link

@Mike4U Mike4U commented May 3, 2021

Changes to allow Teensduino 1.54 beta7

Changes to allow Teensduino 1.54 beta7
@Mike4U
Copy link
Author

Mike4U commented May 3, 2021

Not good with GitHub. Thought I would be able to comment on each file. The AVNA!Config.h is just for me. The Serial ommandR2 changes add a command that can list the commands. The AVNA8commands.ino add a help command with H, HELP or h. This should have been a separate issue.

The main changes are in AVNA8main.ino and AVNAlcd.ino. Got rid of some repetitive includes and added the ones I think 1.54 will need.

I think I should have asked you to make a new branch for me to submit these pulls to. Maybe you still can. That way if you don't like them you just switch back to the previous branch.

@Mike4U
Copy link
Author

Mike4U commented May 3, 2021

Buy the way, these changes won't work in Teensduino 1.53, that's why the separate branch. Github desktop magically changes the files between the two versions when you switch branches.

@boblark
Copy link
Owner

boblark commented May 4, 2021

Mike, thanks for figuring out the SD situation. I took a quick look at the notes at PJRC relative to SDFat for the TD 1.53. I hope this is the final fix for all the SD confusion that SD!

I suggest that we wait for 1.54 to be issued (it appears to be soon) and put your changes in to be compatible with 1.54. People can upgrade to that version of the AVNA as long as they do the same with TD. Would that work? Til then, I will not push anything to confuse matters.

I like the "help" additions. Also, I sorta suspect the 1,3 screen orientation is what is being shipped now. I have 1,1 but if 1,3 is the common one we should make that the default by pulling in your CFG.

Good stuff.

Bob

PS-The comment put in at "git commit" does not seem to have enough flexibility. It leaves a lot of comments less useful than they might be. I try to commit changes that are closely related to reduce the number of strange comments and have multiple commits. Maybe there is a way around all that, but I see a lot of other people with the same problem from grouping of changes.

bicycleGuy added 2 commits May 4, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants