Skip to content

sendRequestToShopify should be handled throw ShopifyException #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stanislavshyloboldcommerce wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sendRequestToShopify should be handled throw ShopifyException #138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98f88f7
sendRequestToShopify should be handeled throw ShopifyException
stanislavshyloboldcommerce Aug 26, 2021
27d9a2f
Revert changes
stanislavshyloboldcommerce Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Services/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use BoldApps\ShopifyToolkit\Exceptions\BadRequestException;
use BoldApps\ShopifyToolkit\Exceptions\NotAcceptableException;
use BoldApps\ShopifyToolkit\Exceptions\NotFoundException;
use BoldApps\ShopifyToolkit\Exceptions\ShopifyException;
use BoldApps\ShopifyToolkit\Exceptions\TooManyRequestsException;
use BoldApps\ShopifyToolkit\Exceptions\UnauthorizedException;
use BoldApps\ShopifyToolkit\Exceptions\UnprocessableEntityException;
Expand Down Expand Up @@ -167,8 +168,8 @@ public function delete($path, $params = [])
}

/**
* @param Request $request
* @param array $cookies
* @param Request $request
* @param array $cookies
* @param string | null $password
*
* $cookies is an array of SetCookie objects. see the Cart service for examples.
Expand All @@ -182,6 +183,7 @@ public function delete($path, $params = [])
* @throws UnprocessableEntityException
* @throws TooManyRequestsException
* @throws BadRequestException
* @throws ShopifyException
*/
private function sendRequestToShopify(Request $request, array $cookies = [], $password = null)
{
Expand Down Expand Up @@ -245,7 +247,7 @@ private function sendRequestToShopify(Request $request, array $cookies = [], $pa
case 429:
throw (new TooManyRequestsException($e->getMessage()))->setResponse($response);
default:
throw $e;
throw (new ShopifyException($e->getMessage()))->setResponse($response);
}
} catch (\Exception $e) {
$response = null;
Expand Down