Open
Conversation
boldrebecca
requested review from
Wryte,
rickywiens,
theRTC204 and
walrusk
as code owners
bmansell
suggested changes
Nov 6, 2018
|
|
||
| /** | ||
| * Class DraftOrderTest. | ||
| */ |
Contributor
There was a problem hiding this comment.
This is a total nitpick: could you remove this class comment?
| $this->cart = $cartService->unserializeModel([ | ||
| 'items' => [], | ||
| 'attributes' => ['cool' => 'yes'], | ||
| ], CartModel::class); |
Contributor
There was a problem hiding this comment.
I think you should move lines 24-27 into the test below since it's only relevant to that specific test case.
Then once you've done that, you could add another test for the case of a cart with multiple note attributes to ensure they're being parsed correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating a JIRA ticket we discovered there are no tests for draft orders, so we wrote one.
This unit test checks that cart attributes are passed from the cart to the draft order.