Skip to content

llm/ant: detect adaptive thinking for qualified model names #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanuck wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −3
Open

llm/ant: detect adaptive thinking for qualified model names #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions llm/ant/ant.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,18 @@ type systemContent struct {
// (thinking: {type: "adaptive"} + output_config: {effort: "..."}) instead of
// the legacy manual thinking (thinking: {type: "enabled", budget_tokens: N}).
// Claude Opus 4.7 and later require adaptive thinking.
// Matching is done on '-'/'.'-delimited tokens so it covers dated snapshots
// ("claude-opus-4-8-20260115") and provider-qualified names
// ("us.anthropic.claude-opus-4-8-v1:0") without false positives like
// "claude-opus-4-80".
func useAdaptiveThinking(model string) bool {
return model == ClaudeFable5 || strings.HasPrefix(model, "claude-fable-5-") ||
model == Claude48Opus || strings.HasPrefix(model, "claude-opus-4-8-") ||
model == Claude47Opus || strings.HasPrefix(model, "claude-opus-4-7-")
model = "-" + strings.ReplaceAll(model, ".", "-") + "-"
for _, m := range []string{ClaudeFable5, Claude48Opus, Claude47Opus} {
if strings.Contains(model, "-"+m+"-") {
return true
}
}
return false
}

// request represents the request payload for creating a message.
Expand Down
26 changes: 26 additions & 0 deletions llm/ant/ant_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,6 +2697,31 @@ func TestWebSearchContentSurvivesJSONRoundTrip(t *testing.T) {
}
}

func TestUseAdaptiveThinking(t *testing.T) {
tests := []struct {
model string
want bool
}{
{Claude48Opus, true},
{Claude47Opus, true},
{ClaudeFable5, true},
{"claude-opus-4-8-20260115", true},
{"anthropic.claude-opus-4-8", true},
{"us.anthropic.claude-opus-4-8-v1:0", true},
{"anthropic.claude-fable-5-20260301-v1:0", true},
{Claude46Opus, false},
{Claude46Sonnet, false},
{"anthropic.claude-sonnet-4-5-20250929-v1:0", false},
{"claude-opus-4-80", false},
{"anthropic.claude-opus-4-85-v1:0", false},
}
for _, tt := range tests {
if got := useAdaptiveThinking(tt.model); got != tt.want {
t.Errorf("useAdaptiveThinking(%q) = %v, want %v", tt.model, got, tt.want)
}
}
}

// TestFromLLMRequestThinkingLevels exercises the per-request ThinkingLevel
// override across both adaptive and budget-style Claude models.
func TestFromLLMRequestThinkingLevels(t *testing.T) {
Expand All @@ -2713,6 +2738,7 @@ func TestFromLLMRequestThinkingLevels(t *testing.T) {
{name: "adaptive req xhigh", model: Claude47Opus, svcLevel: llm.ThinkingLevelMedium, reqLevel: llm.ThinkingLevelXHigh, wantType: "adaptive", wantEffort: "xhigh"},
{name: "adaptive opus48 xhigh", model: Claude48Opus, svcLevel: llm.ThinkingLevelMedium, reqLevel: llm.ThinkingLevelXHigh, wantType: "adaptive", wantEffort: "xhigh"},
{name: "adaptive req off", model: Claude47Opus, svcLevel: llm.ThinkingLevelMedium, reqLevel: llm.ThinkingLevelOff, wantType: ""},
{name: "adaptive provider-qualified opus48", model: "us.anthropic.claude-opus-4-8-v1:0", svcLevel: llm.ThinkingLevelMedium, wantType: "adaptive", wantEffort: "medium"},
{name: "budget default medium", model: Claude45Sonnet, svcLevel: llm.ThinkingLevelMedium, wantType: "enabled", wantBudgetGreat: 8192},
{name: "budget req low", model: Claude45Sonnet, svcLevel: llm.ThinkingLevelMedium, reqLevel: llm.ThinkingLevelLow, wantType: "enabled", wantBudgetGreat: 2048},
{name: "budget req off", model: Claude45Sonnet, svcLevel: llm.ThinkingLevelMedium, reqLevel: llm.ThinkingLevelOff, wantType: ""},
Expand Down