fix(alerts): gate face alerts on minimum person count#6
Merged
Conversation
Face presence skipped the shared person-count threshold, so a single visible face could trigger the highest alert level and made 有人 vs 偵測到臉 indistinguishable in practice. Co-authored-by: Cursor <cursoragent@cursor.com>
Deploying argus with
|
| Latest commit: |
1d62bdb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://149d82e1.argus-bnl.pages.dev |
| Branch Preview URL: | https://fix-face-alert-min-person-co.argus-bnl.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minPersonCount) threshold to face alerts, not only to the有人person state machine.inputas well aschangeso the value saves without requiring blur.Problem
After the graded presence alert work, face detection could fire at the
偵測到臉level even when only one person was on screen and 至少人數 was set to 2+. That made the person-count control appear broken and collapsed the distinction between有人and偵測到臉in normal use.Test plan
npm test(27 tests pass)無人有人sound/lamp; turn to face camera → upgrades to偵測到臉with double tone有人vs偵測到臉sounds differMade with Cursor