Skip to content

force delete orphans#66

Open
lifeofguenter wants to merge 1 commit into
bonclay7:masterfrom
lifeofguenter:force-delete-orhpans
Open

force delete orphans#66
lifeofguenter wants to merge 1 commit into
bonclay7:masterfrom
lifeofguenter:force-delete-orhpans

Conversation

@lifeofguenter
Copy link
Copy Markdown

--

Copy link
Copy Markdown

@TheJefe TheJefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lusitaniae
Copy link
Copy Markdown

Actually, for consistency the confirm code would be in run_cli same as the one cleaning up amis

And it needs to solve the merge conflicts now (after so long)

if not self.force_delete:

Would be good to create a function for that alone, either way it probably works

Any chance to get it reviewed and merged @bonclay7 ?
Possibly you could add someone with merge permissions to the project to keep this going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants