Fix tag name partial match and tag binning#97
Open
jeckhart wants to merge 2 commits into
Open
Conversation
…as a substring of the longer tag
…ing to their alphabetic sort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix a case where tags can match on partial names. For example, I had some AMI's with tags named "image-size" and "image-size-name". When using amicleaner I was passing in image-size-name as a mapping value, but seeing matches on image-size instead.
Additionally, there was another case where if two tags had the same value they could be mapped to the same bin.
I've added tests to test for both cases.