Add JA definitions for 187 synsets missing them#7
Open
fcbond wants to merge 1 commit into
Open
Conversation
- 70 pronoun/demonstrative synsets (wnja-77xxxxx): grammatical glosses covering 1st/2nd/3rd person, demonstratives (これ/それ/あれ etc.), interrogatives (何/誰/どこ/いつ), universals, reflexives, and determiner/adverb uses - 117 Asia/Japan-specific concept synsets (wnja-80xxxxx): prose definitions translated from English for terms including 居酒屋, 参勤交代, お盆, おにぎり, 人工知能, 空心菜, タピオカティー, 少子化, ホーカーセンター, and many others; non-NE entries only - tweak_wnja.py: extend apply_corrections() to support adding new definitions (empty old_value) in addition to replacing existing ones - audit/llm.py: force empty <think> block for Qwen3 models to prevent verbose plain-text reasoning consuming the token budget Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
62cbb3a to
d2810f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wnja-77xxxxx): grammatical glosses for 1st/2nd/3rd person pronouns (私・彼・彼女…), demonstratives (これ/それ/あれ, この/その/あの, こんな/そんな/あんな, こんなに/そんなに/あんなに), interrogatives (何/誰/どこ/いつ/なぜ), universals (みんな/全部), reflexives (自分), and meta-categories (所有代名詞/疑問代名詞)wnja-80xxxxx): prose definitions translated from English — food terms (居酒屋, おにぎり, お盆, タピオカティー, ホーカーセンター, チリクラブ…), cultural concepts (参勤交代, 初夢, 干支, 親孝行, 少子化…), language/tech terms (人工知能, 漢字, 翻訳/通訳, DVD…), and more; named entities excludedtweak_wnja.py:apply_corrections()now supports adding new definitions whenold_valueis empty, in addition to replacing existing onesaudit/llm.py: force empty<think>block for Qwen3 models to prevent verbose plain-text reasoning consuming the token budget (fixes Stage 1 slowdown)Review notes
All definitions are in
corrections/definitions.tsvwithsource=audit/missing-defsanddate=2026-05-30. Please check especially:Test plan
uv run python build_wnja.py && uv run python tweak_wnja.py— verify "196 corrections applied", no WARNINGs on new entriesuv run pytest tests/🤖 Generated with Claude Code