fix(github): scope PR stack comment to current stack only#36
Merged
Conversation
- Filter rendered tree to only show the path from trunk to the current branch and its descendants; sibling stacks are excluded. - Branches without PRs now display `branch: `name`` instead of bare ``name`` for consistency with the PR line format.
Owner
Author
📚 Pull Request Stack
Managed by gh-stack |
There was a problem hiding this comment.
Pull request overview
This PR enhances the GitHub PR stack comment feature to display only the relevant stack for the current branch, filtering out sibling stacks that are not part of the current branch's lineage. Additionally, it standardizes the display format for branches without PRs.
Changes:
- Modified the stack filtering algorithm to show only the path from trunk to current branch plus all descendants, excluding sibling stacks
- Updated the display format for branches without PRs from bare backticks to a consistent "branch:
name" format - Added comprehensive test coverage for the new filtering behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/github/comments.go | Implemented ancestorPath-based filtering in GenerateStackComment and renderTree to show only the current stack, and updated branch display format for consistency |
| internal/github/comments_test.go | Updated existing tests to reflect new branch format and added new test cases to verify correct filtering behavior for siblings and multiple stacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current branch and its descendants; sibling stacks are excluded.
branch:nameinstead of barename`` for consistency with the PR line format.