Enforce "self or admin" authorization on PATCH /users/{id} - #21
Merged
Mats057 merged 3 commits intoMar 1, 2026
Conversation
Co-authored-by: Mats057 <119885089+Mats057@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update user management role and verification patterns
Enforce "self or admin" authorization on PATCH /users/{id}
Mar 1, 2026
Mats057
marked this pull request as ready for review
March 1, 2026 22:31
Mats057
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any authenticated user could modify another user's
username,email,name, orbioby targeting theirid— only therole/accountNonLockedfields had an admin guard.Changes
Auth.java— AddedUSER_SELF_OR_ADMINSpEL constant, mirroring the existingREVIEW_OWNER_OR_ADMINpattern:UserService— AddedisSelf(UUID id, String username)authorization helper (mirrorsReviewService.isOwner)UserController— Added@PreAuthorize(USER_SELF_OR_ADMIN)toPATCH /users/{id}The existing admin-only guard inside
update()forrole/accountNonLockedis retained — users cannot elevate their own role or toggle their lock status.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.