adding support for dot and bracket parameter notation#200
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 70871 | Generic High Entropy Secret | 2a05964 | src/test/java/io/boomerang/tests/controller/WorkflowControllerTests.java | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
tlawrie
left a comment
There was a problem hiding this comment.
Hey @amhudson i think lets do a session on this in the next Boomerang community call. I think we could also be changing this in the Parameter Manager
I've rewritten part of this in https://github.com/boomerang-io/flow.service.engine/blob/main/src/main/java/io/boomerang/service/ParameterManagerImpl.java
It still uses the paramLayers and builds them up. But i think overall we could solve this similar to how you have it.
Closes #
boomerang-io/community#345
Changelog
New
Changed
Removed
Testing / Reviewing
Tested and verified locally