Feat 336 protected values hidden#139
Draft
BenjaminRuby wants to merge 13 commits into
Draft
Conversation
…Content/PropertiesModalContent.tsx Co-authored-by: Tim Bula <timrbula@gmail.com>
…-io/flow.client.web into feat-336-protectedValuesHidden
|
@tlawrie @BenjaminRuby So this means I have to change the type from |
Member
|
Hi @AndreiOla i think the type 'Secured' should only affect the UI, based on previous discussions around not wanting to affect the back end services. But @BenjaminRuby can confirm. |
Member
|
@BenjaminRuby @AndreiOla how have we gone with this one? |
Member
|
Moved to draft state per discussion on community call. Needs further coordination with service changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Related Issues(s):
boomerang-io/community#336
Build Number:
3.7.73.7.83.7.9Checklist:
PR Review Guidance
Additional Info
Addressing @tlawrie 's comments from merged PR: #138
Did not address 3-6-9, I did not know what additional info to stick in the modal. @tlawrie @timrbula evaluate that as you see fit.
I did update some of the helper texts. I did update the password type in global/team/workflow parameters to be
secured