fix GCC Bug 57350: std::align missing#453
Conversation
|
This is the only error generated by gcc-4.x. 09:57:59 /home/api/artifact/gcc-4.8.5/boost-1.89.0/include/boost/asio/buffer.hpp:2872:21: error: missing space between ‘""’ and suffix identifier The code is introduced in d48d95d since boost-1.84 |
|
There was a check about std::align in boost-1.83: which is dropped in commit 5c19f29 ("Require C++11 as the minimum c++ standard.") |
|
Since boost.asio is NOT gtested with gcc-4.x (The minimal version in test summary is gcc-6, https://regression.boost.org/develop/developer/summary.html), I suggest we fix the doc and officially stop support for gcc-4.x. |
|
I've made a PR to the maintainer's repo: |
|
Thanks for your work^^ @hdu-sdlzx |
it will cause compilation failure if use g++<5.0.
The detailed information of the bug can be found: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57350
is that possible to use macro to determine that when the compiler is gcc and the version is less than 5.0, use the source code (g++>=5.0) directly in the call to std::align to obtain asio library support for compilers before gcc 5.0?