Fix compilation on Windows with BOOST_PROCESS_STANDALONE defined#537
Open
jwhitworth-vicon wants to merge 3 commits intoboostorg:developfrom
Open
Fix compilation on Windows with BOOST_PROCESS_STANDALONE defined#537jwhitworth-vicon wants to merge 3 commits intoboostorg:developfrom
jwhitworth-vicon wants to merge 3 commits intoboostorg:developfrom
Conversation
…TANDALONE is defined. `std::error_code::assign` takes two arguments and `::BOOST_PROCESS_V2_NAMESPACE::detail::get_last_error()` is already returning an error code so we can use the assignment operator instead. Also wrapped the statement in a do/while block for safety and to match the other macros in the file.
…er implementation. This causes a compiler error when compiling with `BOOST_PROCESS_STANDALONE` defined.
…one of the basic_process constructor overloads. This was causing a compilation error when `BOOST_PROCESS_STANDALONE` was defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to use Boost.Process with the non-Boost standalone Asio, I found that some of the code in Boost.Process failed to compile when defining
BOOST_PROCESS_STANDALONE,BOOST_PROCESS_V2_STANDALONEandBOOST_PROCESS_USE_STD_FS.These fixes address the issues raised in #535.