Support std::string_view & boost::string_view#18
Open
poyenc wants to merge 2 commits intoboostorg:developfrom
Open
Support std::string_view & boost::string_view#18poyenc wants to merge 2 commits intoboostorg:developfrom
poyenc wants to merge 2 commits intoboostorg:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #18 +/- ##
============================================
+ Coverage 70.95% 88.67% +17.72%
============================================
Files 3 3
Lines 210 212 +2
Branches 74 64 -10
============================================
+ Hits 149 188 +39
+ Misses 18 0 -18
+ Partials 43 24 -19
Continue to review full report at Codecov.
|
Author
|
need to figure out why we have coverage drop |
4d34544 to
02defad
Compare
1. offset_separator 2. char_separator 3. char_delimiters_separator
02defad to
6a3c01b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support both
std::string_viewandboost::string_viewas tokenizer's string type argument for following separators:offset_separatorchar_separatorchar_delimiters_separatorDue to the
escaped_list_separator's transformation semantics, we cannot simply usestd::string_viewas return token type. But in the future, I think we can let users to decide the return token type and input type separately instead of bind them together, to supportescaped_list_separatorin some conditions, e.g. tokenizestd::string_viewtostd::string(s).Changes
assign_or_plus_equalwhich does nothing special.assign()/append()/clear()for token object to replace overload operator usages, and provide customization points to users (find candidates via ADL).Note
This pull request is based on #17, please merge it first.