feat: Make TTL configurable for ExternalDNS integration#218
Merged
Conversation
- Add TTL field to ExternalDNSIntegrationConfig (optional) - Update NewExternalDNS to accept TTL parameter with 300s default - Pass TTL from config to NewExternalDNS in controllers/utils.go - Add unit tests for custom TTL configuration Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
- Update README.md with TTL configuration note - Add TTL field to Helm values.yaml with documentation - Update Helm template to pass TTL to config - Update Helm chart README with TTL parameter documentation Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Owner
|
@claude[agent] run |
Remove extra blank line to pass gofmt check Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Contributor
Author
Pre-commit checks completed. Fixed Go formatting issue in d276acf. Since pixi is not available in this environment, I manually ran the equivalent checks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt