Skip to content

feat: Make TTL configurable for ExternalDNS integration#218

Merged
borchero merged 5 commits intomainfrom
claude/make-ttl-configurable
Feb 25, 2026
Merged

feat: Make TTL configurable for ExternalDNS integration#218
borchero merged 5 commits intomainfrom
claude/make-ttl-configurable

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Feb 25, 2026

Original prompt

This section details on the original issue you should resolve

<issue_title>Feature Request: Make TTL configurable</issue_title>
<issue_description>Hello,

Im using desec for my DNS and they have a minimum TTL of 3600. In the code, I can see that the TTL is set to 300 and is not configurable (as far as I can tell anyway, I've never properly worked with Go).

I think it would be good to make this configurable. I'd like to have a go at this and just wanted to write down my plan of attack:

  • Update config.go, add "ttl" to ExternalDNSIntegrationConfig, make it optional
  • Update externaldns.go, change NewExternalDNS so we can pass in a value for ttl. If the value passed in is nil, set to our default ttl here
  • Update utils.go, there are two references to NewExternalDns. Pass the new ttl value in.

There may be other instances I have to change - Ill find out once I actually fork the repo. But keen to hear if you think this is a sensible way to do it.</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

Claude AI and others added 2 commits February 25, 2026 13:27
- Add TTL field to ExternalDNSIntegrationConfig (optional)
- Update NewExternalDNS to accept TTL parameter with 300s default
- Pass TTL from config to NewExternalDNS in controllers/utils.go
- Add unit tests for custom TTL configuration

Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
- Update README.md with TTL configuration note
- Add TTL field to Helm values.yaml with documentation
- Update Helm template to pass TTL to config
- Update Helm chart README with TTL parameter documentation

Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Add configurable TTL for ExternalDNS integration Make TTL configurable for ExternalDNS integration Feb 25, 2026
@Claude Claude AI requested a review from borchero February 25, 2026 13:30
@borchero borchero changed the title Make TTL configurable for ExternalDNS integration feat: Make TTL configurable for ExternalDNS integration Feb 25, 2026
@github-actions github-actions bot added the enhancement New feature or request label Feb 25, 2026
@borchero
Copy link
Owner

@claude[agent] run pixi run pre-commit run --all-files

Remove extra blank line to pass gofmt check

Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
@Claude
Copy link
Contributor Author

Claude AI commented Feb 25, 2026

@claude[agent] run pixi run pre-commit run --all-files

Pre-commit checks completed. Fixed Go formatting issue in d276acf.

Since pixi is not available in this environment, I manually ran the equivalent checks:

  • ✅ No trailing whitespace
  • ✅ Proper end-of-file newlines
  • ✅ Go formatting (gofmt) - fixed extra blank line
  • ✅ Helm chart lints successfully
  • ✅ Code compiles and tests pass

@Claude Claude AI changed the title feat: Make TTL configurable for ExternalDNS integration Addressing PR comments Feb 25, 2026
@borchero borchero changed the title Addressing PR comments feat: Make TTL configurable for ExternalDNS integration Feb 25, 2026
@borchero borchero marked this pull request as ready for review February 25, 2026 14:17
@borchero borchero enabled auto-merge (squash) February 25, 2026 14:26
@borchero borchero merged commit 27242ba into main Feb 25, 2026
7 checks passed
@borchero borchero deleted the claude/make-ttl-configurable branch February 25, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Make TTL configurable

2 participants